Skip to content

chore: added rootDir to all tsconfig files#559

Draft
gpaoloni wants to merge 2 commits intomasterfrom
gian_set-rootDir
Draft

chore: added rootDir to all tsconfig files#559
gpaoloni wants to merge 2 commits intomasterfrom
gian_set-rootDir

Conversation

@gpaoloni
Copy link
Collaborator

@gpaoloni gpaoloni commented Feb 9, 2024

Description

This PR adds rootDir property to all our tsconfig files.
This is in order to avoid importing resources from other projects, which should instead be imported using the proper package name, like @tech-matters/.... The reason is that referencing a module in a different package directly by a path rather than via it's package reference cause TS to compile with a higher root directory & break when deployed - since the Dockerfile expects the plain root directory resulting from the compile step.

@gpaoloni gpaoloni requested a review from stephenhand February 9, 2024 17:09
@gpaoloni gpaoloni marked this pull request as draft February 9, 2024 17:13
Copy link
Collaborator

@stephenhand stephenhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants