ch: add eslint disable comment to handle import error#456
Open
ch: add eslint disable comment to handle import error#456
Conversation
stephenhand
reviewed
Sep 14, 2023
Collaborator
stephenhand
left a comment
There was a problem hiding this comment.
Do we know why these are being considered 'extraneous dependencies' by eslint for the HRM service?
Normally this happens when you try to use a dev dependency in production code, but the package is in package.json. Also my eslint is not reporting a problem
Before we merge this we should deploy it to staging from this branch to see if it fixes the issue
Be sure to co-ordinate with Annalise over when to deploy as she will be regression testing the new release over the next few days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix: HRM exports aren’t being posted to S3 for six hours.
Cause:
Solution was to add
// eslint-disable-next-line import/no-extraneous-dependenciescomment in other to allow@tech-matters/s3-client/distbuild properlyChecklist
Related Issues
Fixes #....
Verification steps