[draft] chore: add sonarjs plugin to eslint to get cognitive complexity scores#403
Open
robert-bo-davis wants to merge 1 commit intomasterfrom
Open
[draft] chore: add sonarjs plugin to eslint to get cognitive complexity scores#403robert-bo-davis wants to merge 1 commit intomasterfrom
robert-bo-davis wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
Just wondering how we address the fails so we can merge it without a broken build? We could put '@' comments on the places where it fails and they could look at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds sonarjs rules to eslint primarily to give us cognitive complexity linting, but there are a few other useful rules it adds.