CHI-3707: Add unit tests for current user identity check in conversation masking#3873
CHI-3707: Add unit tests for current user identity check in conversation masking#3873Copilot wants to merge 4 commits intoCHI-3707-mask_participants_missing_from_reduxfrom
Conversation
…unction Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
stephenhand
left a comment
There was a problem hiding this comment.
Please add the additional tests specifically around cases where the participant is the current user to plugin-hrm-form/src/_tests/maskIdentifiers/index.test.ts rather than recreating the whole suite under a different file name
For all future commits please run eslint for plugin-hrm-form with its defined configuration and fix any issues before requesting a review
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
I've renamed the test file to
All 9 tests still pass. Commit: 80ef046 |
stephenhand
left a comment
There was a problem hiding this comment.
Your branch was not up to date with the relevant changes. Start again with the original requirement now your branch is the correct baseline
Run eslint for plugin-hrm-form and fix any issues as a precondition for requesting a review
I've updated the branch to the latest base and added tests specifically for the current user identity check to the existing Tests added:
All 20 tests pass (15 existing + 5 new) and eslint passes with no errors. Commit: ba4f06f |
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.