chore: Implement webchat pre-engagement form - fetch definitions [CHI-3618]#3865
Merged
chore: Implement webchat pre-engagement form - fetch definitions [CHI-3618]#3865
Conversation
…dWebchatDefinition
stephenhand
approved these changes
Feb 5, 2026
Collaborator
stephenhand
left a comment
stephenhand
left a comment
There was a problem hiding this comment.
Great work here Gian. Couple of non blocking comments
| } No newline at end of file | ||
| "environment": "development", | ||
| "aseloBackendUrl": "https://hrm-development.tl.techmatters.org", | ||
| "definitionVersion": "as-v1" |
Collaborator
There was a problem hiding this comment.
Should this be in common.json?
| sessionDataHandler.setDeploymentKey(webchatConfig.deploymentKey); | ||
|
|
||
| store.dispatch(initConfig(webchatConfig)); | ||
| await store.dispatch(initConfigThunk(webchatConfig) as any); |
Collaborator
There was a problem hiding this comment.
Can we move the code above that loads the config into the thunk as well?
Collaborator
Author
There was a problem hiding this comment.
I'll do this in a subsequent PR, as moving it now breaks some tests - it'll demand a few more minutes than just moving the code around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
lambdas/packages/hrm-form-definitions/src/formDefinition/(and plugin) to factor out code used to fetch definitions versions, in order to share between plugin and aselo webchat./webchat/PreEngagementForm.jsonform definition file to centralize helpline customizations.initConfigThunkintroduced to load the form definitions upon webchat initialization.Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P