Move shell execution off tokio async threads to blocking thread pool #70
+89
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shell commands now use std::process::Command + spawn_blocking instead of tokio::process::Command, keeping shell I/O entirely off async worker threads. Also fixes a latent pipe deadlock: the old code read stdout then stderr sequentially, which could deadlock if the child filled stderr's pipe buffer. Now uses wait_with_output() which reads both streams in parallel. https://claude.ai/code/session_01EfWPKurCSP4NaVGpAaFQYv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell commands now use std::process::Command + spawn_blocking instead of
tokio::process::Command, keeping shell I/O entirely off async worker threads.
Also fixes a latent pipe deadlock: the old code read stdout then stderr
sequentially, which could deadlock if the child filled stderr's pipe buffer.
Now uses wait_with_output() which reads both streams in parallel.
https://claude.ai/code/session_01EfWPKurCSP4NaVGpAaFQYv