Conversation
Ms2ger
reviewed
Jan 7, 2026
Ms2ger
requested changes
Jan 7, 2026
catamorphism
force-pushed
the
v8-staging-calendar-date-from-fields
branch
from
3eee230 to
5b07939
Compare
Ms2ger
reviewed
Jan 14, 2026
Ms2ger
approved these changes
Jan 16, 2026
And move functionality into existing tests.
…-bag.js Co-authored-by: Ms2ger <Ms2ger@gmail.com>
…erty-bag.js Co-authored-by: Ms2ger <Ms2ger@gmail.com>
…erty-bag.js Co-authored-by: Ms2ger <Ms2ger@gmail.com>
Ms2ger
force-pushed
the
v8-staging-calendar-date-from-fields
branch
from
70641ed to
f67b11b
Compare
trflynn89
reviewed
Jan 16, 2026
| `${description} does not convert to a valid ISO string` | ||
| ); | ||
|
|
||
| for (options of [undefined, { overflow: 'constrain' }, { overflow: 'reject' }]) { |
Contributor
There was a problem hiding this comment.
FYI - there are a handful of tests that are invalid when run in strict mode. i.e.:
'use strict';
for (options of [undefined, { overflow: 'constrain' }, { overflow: 'reject' }]) {
}Will throw a ReferenceError for options. The declaration should probably be for (const options.
Contributor
There was a problem hiding this comment.
Thanks for flagging. I can review a PR to fix that quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move functionality into existing tests.