Normative: Ignore "islamic-rgsa" calendar in DateTimeFormat #99
Conversation
Following guidance in [issue tc39#29 conversation](tc39#29 (comment)), this PR causes the value of `"ca"` to be removed from the `_options_` of `CreateDateTimeFormat` when the value of `_options_.[[ca]]` is "islamic-rgsa". This calendar matches no calendar in actual use and should be ignored.
ryzokuken
force-pushed
the
issue-29-hijri-calendars
branch
from
cff02fb to
3ade73a
Compare
ryzokuken
changed the title
"islamic-rgsa" calendar option
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Based on the discussion from yesterday's TG2 I think here's what we need to change in this PR:
- delete the added text, it's no longer relevant
- delete the "islamic-rgsa" from the If-clause a few lines lower down
- change the fallbackCalendar and CanonicalizeUValue lines to simply "Set resolvedCalendar to "islamic-tbla"."
- in AvailableCalendars, change "The List must include" to "The List must consist of"
ben-allen
force-pushed
the
issue-29-hijri-calendars
branch
from
3ade73a to
be6c4b1
Compare
|
Updated per @ptomato's suggestion |
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Sorry, didn't occur to me before, but I think this section also needs to change. At least "even if supporting only the calendars from Table 1" needs to be rephrased, since it's now required to support only the calendars from Table 1.
Possibly something like "This list may include calendar types not listed in Table 1"?
…ion for internal slots of Intl.DateTimeFormat constructor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I just realized we additionally need to comb through the proposal and remove any language that says "If calendar is not listed in Table 1, return an implementation-defined value" — that will no longer be allowed.
…bleCalendars`, no longer "must include" all the calendar types in Table 1 (Calendar types described in CLDR), but instead must entirely consist of the calendar types in Table 1. As a result, `AvailableCalendars` and two other AOs: * `CalendarExtraFields` * `NonISOFieldKeysToIgnore` are likewise not implementation-defined. Steps in these AOs returning implementation-defined values for calendar types not in Table 1 have been removed.
|
As of the last commit this PR would fix #94 |
|
Is there anything in particular blocking this from landing? |
|
It needs to be presented to TG1, no? |
ben-allen
moved this from Previously Discussed
to Priority Issues
in ECMA-402 Meeting Topics
4 participants
Following guidance in issue #29 conversation, this PR causes the value of
"ca"to be removed from the_options_ofCreateDateTimeFormatwhen the value of_options_.[[ca]]is"islamic-rgsa". This calendar matches no calendar in actual use and should be ignored.fix #94