Skip to content

feat: support accepting TCP connections through net.Listener #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtext wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support accepting TCP connections through net.Listener #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions servetcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,19 @@ func (s *Server) accept(listen net.Listener) error {
}
}

func (s *Server) ListenWithListener(listen net.Listener) {
s.listeners = append(s.listeners, listen)
go s.accept(listen)
}

// ListenTCP starts the Modbus server listening on "address:port".
func (s *Server) ListenTCP(addressPort string) (err error) {
listen, err := net.Listen("tcp", addressPort)
if err != nil {
log.Printf("Failed to Listen: %v\n", err)
return err
}
s.listeners = append(s.listeners, listen)
go s.accept(listen)
s.ListenWithListener(listen)
return err
}

Expand All @@ -67,7 +71,6 @@ func (s *Server) ListenTLS(addressPort string, config *tls.Config) (err error) {
log.Printf("Failed to Listen on TLS: %v\n", err)
return err
}
s.listeners = append(s.listeners, listen)
go s.accept(listen)
s.ListenWithListener(listen)
return err
}