fix: Replace deprecated datetime.utcnow() with timezone-aware alterna…

[AnsahMohammad]

Replaced instances of datetime.datetime.utcnow() with datetime.datetime.now(datetime.UTC) to address deprecation warnings while running pytest.

[jcristau]

Thanks for the patch.

You'll need to use datetime.timezone.utc, as datetime.UTC was only added in python 3.11.

[AnsahMohammad]

Thanks for the patch.

You'll need to use datetime.timezone.utc, as datetime.UTC was only added in python 3.11.

Just did that, please check now

[AnsahMohammad]

@jcristau Hey, I noticed that the firefoxci-taskcluster / Decision Task failed due to some time-formatting issues. However, the tests didn't catch any errors. Would you suggest extending the test coverage to include this as well?

[jcristau]

@jcristau Hey, I noticed that the firefoxci-taskcluster / Decision Task failed due to some time-formatting issues. However, the tests didn't catch any errors. Would you suggest extending the test coverage to include this as well?

Sounds like a good idea, yes :)

[AnsahMohammad]

@jcristau Hey, I noticed that the firefoxci-taskcluster / Decision Task failed due to some time-formatting issues. However, the tests didn't catch any errors. Would you suggest extending the test coverage to include this as well?

Sounds like a good idea, yes :)

I went through the codebase and found this :

            except KeyError:
                # go on to the next index path
                pass

taskgraph/src/taskgraph/optimize/strategies.py

Line 66 in 63ec732

except KeyError:

This made the test case miss the time-format issue on tests. I am not sure if it'll be a good idea to replace the "pass" statement here as any error might break the flow. I am confused on how to proceed.

[jcristau]

@AnsahMohammad I've pushed a commit to your branch to add a test and fix the issue that was breaking the decision task.

[AnsahMohammad]

@AnsahMohammad I've pushed a commit to your branch to add a test and fix the issue that was breaking the decision task.

Thanks for the commit 👍.
I thought it was another file causing the error.

[jcristau]

Updated to pull in #659 and trigger the required complete-pr task.

[jcristau]

Added the "breaking change" label because both json_time_from_now and current_json_time with datetime_format=True now return a timezone-aware object.