Skip to content
This repository was archived by the owner on Sep 26, 2022. It is now read-only.

Get rid of OrderedDicts#310

Open
ritikramuka wants to merge 2 commits into
talaia-labs:masterfrom
ritikramuka:OrderedDict
Open

Get rid of OrderedDicts#310
ritikramuka wants to merge 2 commits into
talaia-labs:masterfrom
ritikramuka:OrderedDict

Conversation

@ritikramuka

Copy link
Copy Markdown

addressing the issue: #233

Changed OrderedDict to dict as in python ^3.7 dict are ordered by default

@sr-gi

sr-gi commented Feb 24, 2022

Copy link
Copy Markdown
Member

@ritikramuka there was some issues with circle-ci so i had to roll an update. Can you rebase master so ci tests are run again?

@ritikramuka

Copy link
Copy Markdown
Author

@sr-gi can you help me figure out where the test is failing!

@sr-gi

sr-gi commented Feb 25, 2022

Copy link
Copy Markdown
Member

Have you run the test locally?

Looks like you've replaced OrderedDict by dict but you have not updated the methods. Here's the traceback:

Traceback (most recent call last):
    File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
      self.run()
    File "/usr/lib/python3.8/threading.py", line 870, in run
      self._target(*self._args, **self._kwargs)
    File "/home/circleci/project/teos/watcher.py", line 491, in do_watch
      self.locator_cache.update(block_hash, locator_txid_map)
    File "/home/circleci/project/teos/watcher.py", line 119, in update
      self.remove_oldest_block()
    File "/home/circleci/project/teos/watcher.py", line 130, in remove_oldest_block
      block_hash, locators = self.blocks.popitem(last=False)
  TypeError: popitem() takes no keyword arguments

@ritikramuka

Copy link
Copy Markdown
Author

@sr-gi I am not able to run any test locally... as having an issue setting up leveldb and plyvel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants