client: apply partial results from a failed poll attempt #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
force-pushed
the
mjf/poll-better
branch
from
311acdf to
97f8da1
Compare
When updating multiple secrets during a refresh, it is possible some may fail, for example if a secret that was previously declared is now gone. Before reporting this error to the caller, apply any updates that succeeded, so that the store will not get "stuck" by a single failure. Updates tailscale/corp#35650
creachadair
force-pushed
the
mjf/poll-better
branch
from
97f8da1 to
55f244a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating multiple secrets during a refresh, it is possible some may fail,
for example if a secret that was previously declared is now gone. Before
reporting this error to the caller, apply any updates that succeeded, so that
the store will not get "stuck" by a single failure.
Updates tailscale/corp#35650