Skip to content

fix: update task.slot_mapping in _set_slot_mapping_impl#174

Merged
linhu-nv merged 1 commit into
taco-project:mainfrom
xianweihuihuan:fix/kvtask-slot-mapping-not-updated
Jun 2, 2026
Merged

fix: update task.slot_mapping in _set_slot_mapping_impl#174
linhu-nv merged 1 commit into
taco-project:mainfrom
xianweihuihuan:fix/kvtask-slot-mapping-not-updated

Conversation

@xianweihuihuan

Copy link
Copy Markdown
Contributor

Problem

In _set_slot_mapping_impl, task.graph GPU block ids and task.status
were updated, but task.slot_mapping was not.

This caused merge_to_batch_kvtask to read the fake zero slot_mapping
set during create_get_task, leading to incorrect batch KV task merging.

Fix

Add task.slot_mapping = slot_mapping after updating the graph,
ensuring the task reflects the real slot mapping before status is
set to READY.

@linhu-nv linhu-nv self-requested a review June 2, 2026 01:53

@linhu-nv linhu-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really a big issue. I am just curious why this is not exposed earlier to us. Anyway thanks for the fix.

@linhu-nv linhu-nv merged commit 847cc66 into taco-project:main Jun 2, 2026
1 of 2 checks passed
@xianweihuihuan

Copy link
Copy Markdown
Contributor Author

Thanks for the kind words! I noticed it while studying the codebase
for my own project. Happy to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants