fix: update task.slot_mapping in _set_slot_mapping_impl#174
Merged
linhu-nv merged 1 commit intoJun 2, 2026
Merged
Conversation
linhu-nv
approved these changes
Jun 2, 2026
linhu-nv
left a comment
Collaborator
There was a problem hiding this comment.
that's really a big issue. I am just curious why this is not exposed earlier to us. Anyway thanks for the fix.
Contributor
Author
|
Thanks for the kind words! I noticed it while studying the codebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
_set_slot_mapping_impl,task.graphGPU block ids andtask.statuswere updated, but
task.slot_mappingwas not.This caused
merge_to_batch_kvtaskto read the fake zero slot_mappingset during
create_get_task, leading to incorrect batch KV task merging.Fix
Add
task.slot_mapping = slot_mappingafter updating the graph,ensuring the task reflects the real slot mapping before status is
set to READY.