Skip to content

Fix Config::load reading one byte past the end of the config #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexey-milovidov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Config::load reading one byte past the end of the config #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/SZ3/utils/Config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,13 @@ class Config {
* @param c Pointer to the byte array.
*/
void load(const unsigned char*& c) {
const unsigned char* c0 = c;
uchar confSize = 0;
read(confSize, c);
auto c1 = c + confSize;
// `confSize` is the total size of the serialized config, including this length-prefix byte
// (see save()). The end of the config is therefore c0 + confSize, not c + confSize: the latter
// is one byte too far because `c` has already advanced past the prefix byte.
auto c1 = c0 + confSize;

read(N, c);
uint8_t bitWidth;
Expand Down