Skip to content

chore: update development tooling for v1.0.1 - #60

Merged
1kresh merged 6 commits into
mainfrom
codex/update-foundry-tooling
Sep 3, 2026
Merged

1kresh merged 6 commits into
mainfrom
codex/update-foundry-tooling

Conversation

@1kresh

@1kresh 1kresh commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Prepare @symbioticfi/relay-contracts v1.0.1 with updated Foundry and pre-commit tooling. Synchronize the package and lockfile root versions, update forge-std from v1.11.0 to v1.16.2, and pin Foundry v1.8.1 in both CI workflows.

Foundry v1.8.1 resolves nested dependency remappings independently, which made Relay and Core integration tests import different copies of Test. Add an explicit root forge-std remapping and the six whitespace-only changes required by its formatter.

Replace the archived Prettier mirror with a local pnpm hook and pin the binding generators. The TypeScript generator now applies the pinned formatter before returning, so regeneration preserves the checked-in output. Pre-commit installs abigen in an isolated Go hook environment; its refreshed output adds only standard-library context and time references to the 31 Go binding files.

Tooling versions

  • pre-commit 4.6.2 and pre-commit-hooks v6.0.0.
  • Prettier 3.9.6 and wagmi CLI 2.10.0 through pnpm; document pnpm 11.25.0 for local setup.
  • abigen from go-ethereum v1.17.5.
  • Node.js 24.20.0 LTS in .nvmrc, Python 3.14 and pip 26.2.1 in pre-commit CI.
  • SHA-pinned pre-commit CI actions: checkout v7.0.1, setup-python v7.0.0, foundry-toolchain v1.9.1, and Bullfrog v0.11.1.

Validation

  • Foundry v1.8.1 archive passed SHA-256 and GitHub attestation checks; Node.js v24.20.0 archive passed its official SHA-256 check.
  • All 388 Solidity tests compile with the explicit root forge-std remapping. The 383 tests without a mainnet fork passed across 45 suites with 1,000 fuzz runs. The five fork tests require ETH_RPC_URL, unavailable locally; CI retains the full test and coverage commands.
  • forge fmt --check passed with v1.8.1. The six Solidity source/test file changes preserve every non-whitespace token.
  • Pre-commit 4.6.2 passes repository-wide with the existing CI exclusions.
  • A broader local run also passes with both binding generators and Prettier enabled: SKIP=forge-snapshots,generate-abis,end-of-file-fixer pre-commit run --all-files --show-diff-on-failure, using Node.js 24.20.0 and pnpm 11.25.0. The existing CI exclusions remain unchanged.
  • All 31 generated Go bindings compile individually against go-ethereum v1.17.5. The existing directory contains repeated generated struct names and cannot be compiled as one aggregate Go package.
  • TypeScript regeneration plus formatting leaves the checked-in file unchanged. ABI files are unchanged.
  • Both package JSON files parse successfully; their three root version fields are 1.0.1.
  • Pre-commit configuration validation, Python dependency checks, and git diff --check passed.

Before merge

CONTRIBUTING.md requires signed commits. The initial Foundry tooling commit is unsigned because no local signing key is configured; GitHub's signed file-commit API does not support changing a gitlink. That commit must be signed before merging. The version bump and pre-commit update commits are GitHub-signed.

@1kresh
1kresh force-pushed the codex/update-foundry-tooling branch from 58b48e9 to 4d89d3d Compare September 3, 2026 10:21
@1kresh
1kresh marked this pull request as ready for review September 3, 2026 10:32
@1kresh
1kresh requested a review from a team as a code owner September 3, 2026 10:32
@1kresh 1kresh changed the title chore: update Foundry and forge-std chore: update Foundry tooling and bump package to 1.0.1 Sep 3, 2026
@1kresh 1kresh changed the title chore: update Foundry tooling and bump package to 1.0.1 chore: update development tooling for v1.0.1 Sep 3, 2026
@1kresh
1kresh merged commit aa02de9 into main Sep 3, 2026
5 checks passed
@1kresh
1kresh deleted the codex/update-foundry-tooling branch September 3, 2026 11:31
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant