pull project and repo values from git context#12
Open
LoganBarnett wants to merge 1 commit intoswisscom:masterfrom
Open
pull project and repo values from git context#12LoganBarnett wants to merge 1 commit intoswisscom:masterfrom
LoganBarnett wants to merge 1 commit intoswisscom:masterfrom
Conversation
This makes it such that `--key` and `--name` are no longer required if the repository has enough information to be derived (namely from the git remote). This should make CLI usage more ergonomic. The arguments are not gone, so any automation that enjoys these will be unaffected. Earmarked is the exclusion of integration tests if the Bitbucket server is not configured. I am not fluent in Go, but I am told this is a common pattern for integration tests in a Go repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it such that
--keyand--nameare no longer required if therepository has enough information to be derived (namely from the git remote).
This should make CLI usage more ergonomic. The arguments are not gone, so any
automation that enjoys these will be unaffected.
Earmarked is the exclusion of integration tests if the Bitbucket server is not
configured. I am not fluent in Go, but I am told this is a common pattern for
integration tests in a Go repo.