-
Notifications
You must be signed in to change notification settings - Fork 99
jextract/jni: Specialization and constrained extension support #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
Samples/SwiftJavaExtractJNISampleApp/Sources/MySwiftLibrary/BoxSpecialization.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2024-2026 Apple Inc. and the Swift.org project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of Swift.org project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| public struct Box<Element> { | ||
| public var count: Int64 | ||
|
|
||
| public init(count: Int64) { | ||
| self.count = count | ||
| } | ||
| } | ||
|
|
||
| public struct Fish { | ||
| public var name: String | ||
|
|
||
| public init(name: String) { | ||
| self.name = name | ||
| } | ||
| } | ||
|
|
||
| extension Box where Element == Fish { | ||
| public func describeFish() -> String { | ||
| "A box of \(count) fish" | ||
| } | ||
| } | ||
|
|
||
| public typealias FishBox = Box<Fish> | ||
59 changes: 59 additions & 0 deletions
59
...s/SwiftJavaExtractJNISampleApp/src/test/java/com/example/swift/BoxSpecializationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2024-2026 Apple Inc. and the Swift.org project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of Swift.org project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| package com.example.swift; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.lang.reflect.Method; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class BoxSpecializationTest { | ||
| @Test | ||
| void fishBoxHasExpectedMethods() throws Exception { | ||
| // Verify FishBox class exists and has the expected methods | ||
| Class<?> fishBoxClass = FishBox.class; | ||
| assertNotNull(fishBoxClass); | ||
|
|
||
| // Base type property getter | ||
| Method getCount = fishBoxClass.getMethod("getCount"); | ||
| assertNotNull(getCount); | ||
| assertEquals(long.class, getCount.getReturnType()); | ||
|
|
||
| // Base type property setter | ||
| Method setCount = fishBoxClass.getMethod("setCount", long.class); | ||
| assertNotNull(setCount); | ||
|
|
||
| // Constrained extension method (only on FishBox, not on Box) | ||
| Method describeFish = fishBoxClass.getMethod("describeFish"); | ||
| assertNotNull(describeFish); | ||
| assertEquals(String.class, describeFish.getReturnType()); | ||
| } | ||
|
|
||
| @Test | ||
| void fishBoxDoesNotHaveGenericTypeParameter() { | ||
| // FishBox is a concrete specialization — no generic type parameters | ||
| assertEquals(0, FishBox.class.getTypeParameters().length, | ||
| "FishBox should have no generic type parameters"); | ||
| } | ||
|
|
||
| @Test | ||
| void boxHasGenericTypeParameter() { | ||
| // Box<Element> retains its generic parameter | ||
| assertEquals(1, Box.class.getTypeParameters().length, | ||
| "Box should have one generic type parameter"); | ||
| assertEquals("Element", Box.class.getTypeParameters()[0].getName()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This triggers specialization for a new FishBox "type" on the java side 🐟