feat: support for input with mix of mono and multitrack audiostreams#33
Open
grusell wants to merge 1 commit intosvt:masterfrom
Open
feat: support for input with mix of mono and multitrack audiostreams#33grusell wants to merge 1 commit intosvt:masterfrom
grusell wants to merge 1 commit intosvt:masterfrom
Conversation
Previously, encore would fail the job if the input had a mix of mono and multitrack audiostreams, except if the first stream was multitrack. This feat adds some support for inputs with a mix of mono and multitrackstreams, where the first stream is a monostream. Given such an input, encore now uses all monostreams that comes before the first multitrack stream, and ignore all following audiostreams. Signed-off-by: Gustav Grusell <gustav.grusell@eyevinn.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems to be reasonably common to store a multitrack (stereo) 'Dolby E' stream together with multiple other mono streams in an MXF file. Previously, encore would fail the job if the input had a mix of mono and multitrack audiostreams, except if the first stream was multitrack. This feat adds some support for inputs with a mix of mono and multitrack streams, where the first stream is a mono stream. Given such an input, encore now uses all mono streams that comes before the first multitrack stream, and ignore all following audiostreams.
Note that the support for mixed multi-/monotrack streams is limited in the sense that it does not allow use of all input streams in such a case, only the monostreams that comes before the first multitrack stream can be used. A more complete solution was deemed to complex at the moment.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: