fix virtio console reactivation after reset - #120
Open
jonaswre wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The virtio-console backend treats activation as one-shot and leaves ports marked active after shutdown. After a valid virtio reset, a second guest activation is not handled and the port worker threads are not restarted. This breaks Linux hibernation/resume and any other device reset lifecycle.
Fix
Inactivebefore joining its workers so the nextPORT_OPENrestarts them.Validation
cargo test -p msb_krun_devices --lib(79 passed)cargo clippy -p msb_krun_devices --lib --tests -- -D warningswas attempted but is blocked by 14 pre-existing warnings in unrelated legacy/descriptor tests under Rust 1.97.0.