fix: preserve expression value types in json bodies#5628
Open
re-pixel wants to merge 2 commits into
Open
Conversation
Signed-off-by: re-pixel <relja.brdar@gmail.com>
|
👋 Commands for maintainers:
|
PR Risk ReviewRisk: 42/100 (medium) SummaryThis PR fixes type preservation for expression values in JSON bodies by adding type-aware resolution for object, number, and boolean fields, with comprehensive tests covering the key scenarios. Concerns
|
PR Risk ReviewRisk: 50/100 (medium) SummaryCould not parse Claude review JSON. Concerns
Key observations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4499
Preserves expression result types inside JSON request bodies for the HTTP action. Whole-value expressions in object/JSON fields now resolve to their native types, so numbers and booleans stay as JSON numbers/booleans, while partial string templates still render as strings.