feat: add read-only configuration view for component sidebar#5246
Merged
Conversation
Replace the disabled-form overlay with a compact read-only layout, wire Edit mode entry from live view, preserve sidebar tab when switching nodes, and polish Docs tab and tab bar styling. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
👋 Commands for maintainers:
|
superplane-policy-bot
Bot
requested review from
andrecalil,
forestileao,
lucaspin and
shiroyasha
Collaborator
|
I love that we are fixing this. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Restore mapper-driven component UI below ConfigurationView so webhook URLs, schedule info, and similar content remain visible in live/read-only sidebar mode. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Refactor display model builders and DocsTab sections to stay within complexity and max-params limits, and apply prettier formatting. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Force Settings when opening the sidebar or selecting a node with a configuration warning in edit mode, preserve the active tab otherwise, and skip tab updates when re-clicking the same node. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Only show connected integration details when the node's saved integrationRef matches an installation; otherwise display not connected. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Build the read-only display model from the node's persisted integrationRef instead of edit-mode local state that auto-selects the first installation. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Do not mutate selectedIntegration while the sidebar is read-only, and still open Settings when re-clicking a node with a configuration warning in edit mode. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Format expression values before URL detection, expand object schema fields when values are missing, and show integration type alongside not-connected status. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Treat url field values as plain text when they fail URL validation, and guard link rendering so non-http(s) schemes are not clickable. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Return to the Latest tab when selecting a different node with the sidebar already open, unless edit mode or a configuration warning requires Settings. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 94f39e7. Configure here.
Add display-layer tests so javascript: and other non-http(s) values never render as clickable anchors in the configuration view. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the user's selected Settings or Docs tab when clicking another node with the sidebar already open, instead of resetting to Runs. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
forestileao
reviewed
Jun 9, 2026
Use an explicit ready/error check with pending fallback instead of a nested ternary when building read-only integration status rows. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
❌ OSS Guard found dependency licenses that are not permitted for this project. Project license (from repository): Apache-2.0 Permitted dependency licenses: MIT,Apache-2.0,BSD-2-Clause,BSD-3-Clause,ISC,0BSD,Unlicense,CC0-1.0,CC-BY-4.0,Zlib,MPL-2.0,OpenSSL,BlueOak-1.0.0 Reason: One or more dependencies use licenses that are not compatible with the project license. osv-scanner report: Add approved exceptions in your repository's |
Move node-click tab selection into helpers so handleNodeClick stays within the repo-wide max-statements violation cap. Signed-off-by: Petar Perovic <perovic.petar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
❌ OSS Guard found dependency licenses that are not permitted for this project. Project license (from repository): Apache-2.0 Permitted dependency licenses: MIT,Apache-2.0,BSD-2-Clause,BSD-3-Clause,ISC,0BSD,Unlicense,CC0-1.0,CC-BY-4.0,Zlib,MPL-2.0,OpenSSL,BlueOak-1.0.0 Reason: One or more dependencies use licenses that are not compatible with the project license. osv-scanner report: Add approved exceptions in your repository's |
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the disabled-form overlay with a compact read-only layout, wire Edit mode entry from live view, preserve sidebar tab when switching nodes, and polish Docs tab and tab bar styling.