Repository navigation
Match the ask test fixture to the real response shape - #2
Merged
Merged
Conversation
The fixture used intent.keywords; the API returns intent.search_query and a top-level query. Typing it as AskResponse lets typecheck catch this drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
test/tools.test.ts里ask的 mock 响应改成和真实返回一致：intent.keywords改为intent.search_query，并补上顶层的queryAskResponse类型，以后字段名写错 typecheck 会直接报错（已确认：写回keywords时 tsc 报 TS2353）只改测试，不影响发布的包，不需要发版。
验证
/ask调用的返回