Fix media extraction when video_versions is null#2714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
video_versions: nullin media, resource, direct media, and story extractorsxdt_api__v1__media__shortcode__web_infopayloads with null video versionsNotes
video_versions.media/{pk}/info/remains the verified source forplay_count.Tests
PYTHONDONTWRITEBYTECODE=1 .venv/bin/pytest -q tests/regression/test_public.py::PublicRegressionTestCase::test_media_info_handles_web_info_payload_with_null_video_versions tests/regression/test_public.py::PublicRegressionTestCase::test_media_info_gql_extracts_current_web_info_payload tests/regression/test_media.py::MediaInfoV2RegressionTestCase::test_extract_media_v1_normalizes_video_view_countPYTHONDONTWRITEBYTECODE=1 .venv/bin/pytest -q tests/regression/test_public.py tests/regression/test_media.pyPYTHONDONTWRITEBYTECODE=1 .venv/bin/ruff check instagrapi/extractors.py tests/regression/test_public.pygit diff --check