Skip to content

fix: Add support for 0.35.0-unreleased version#359

Open
lorrod wants to merge 1 commit intosubquery:mainfrom
lorrod:main
Open

fix: Add support for 0.35.0-unreleased version#359
lorrod wants to merge 1 commit intosubquery:mainfrom
lorrod:main

Conversation

@lorrod
Copy link

@lorrod lorrod commented Jan 21, 2026

Add support for indexing the SEI network using sei-tendermint (v0.35.0-unreleased)

SEI uses a custom Tendermint fork that exposes finalize_block_events, which aligns most closely with CometBFT v0.38 behavior.

Ref: https://github.com/sei-protocol/sei-tendermint/blob/4776b0013503fe8bfb25e207d2e37d274df0b5d2/rpc/coretypes/responses.go#L70

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested locally
  • I have performed a self review of my changes

Summary by CodeRabbit

  • Improvements
    • Extended SEI network compatibility to support the 0.35.0-unreleased version, enabling seamless operation with the latest network updates.

✏️ Tip: You can customize this high-level summary in your review settings.

Add support for indexing the SEI network using sei-tendermint (v0.35.0-unreleased)

SEI uses a custom Tendermint fork that exposes `finalize_block_events`,
which aligns most closely with CometBFT v0.38 behavior.

Ref: https://github.com/sei-protocol/sei-tendermint/blob/4776b0013503fe8bfb25e207d2e37d274df0b5d2/rpc/coretypes/responses.go#L70
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

Adds support for SEI network's 0.35.0-unreleased Tendermint version by expanding the version check logic for Comet38 client selection. The conditional now recognizes versions starting with "0.35.0-unreleased" as compatible with Comet38Client, with added documentation comments explaining this behavior.

Changes

Cohort / File(s) Summary
SEI Network Tendermint Version Support
packages/node/src/indexer/cosmosClient.connection.ts
Updated version detection conditional to recognize SEI's 0.35.0-unreleased Tendermint version as compatible with Comet38Client; added explanatory comments for the version check logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through version lands,
Finding SEI with eager hands,
0.35.0 shines so bright,
Comet38 now fits just right! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: Add support for 0.35.0-unreleased version' directly and specifically describes the main change—adding support for the 0.35.0-unreleased Tendermint version for SEI network compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant