fix: Add support for 0.35.0-unreleased version#359
Open
lorrod wants to merge 1 commit intosubquery:mainfrom
Open
fix: Add support for 0.35.0-unreleased version#359lorrod wants to merge 1 commit intosubquery:mainfrom
lorrod wants to merge 1 commit intosubquery:mainfrom
Conversation
Add support for indexing the SEI network using sei-tendermint (v0.35.0-unreleased) SEI uses a custom Tendermint fork that exposes `finalize_block_events`, which aligns most closely with CometBFT v0.38 behavior. Ref: https://github.com/sei-protocol/sei-tendermint/blob/4776b0013503fe8bfb25e207d2e37d274df0b5d2/rpc/coretypes/responses.go#L70
📝 WalkthroughWalkthroughAdds support for SEI network's 0.35.0-unreleased Tendermint version by expanding the version check logic for Comet38 client selection. The conditional now recognizes versions starting with "0.35.0-unreleased" as compatible with Comet38Client, with added documentation comments explaining this behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for indexing the SEI network using sei-tendermint (v0.35.0-unreleased)
SEI uses a custom Tendermint fork that exposes
finalize_block_events, which aligns most closely with CometBFT v0.38 behavior.Ref: https://github.com/sei-protocol/sei-tendermint/blob/4776b0013503fe8bfb25e207d2e37d274df0b5d2/rpc/coretypes/responses.go#L70
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.