Creating Strongback gradle project structure#108
Open
jmcshane wants to merge 9 commits intostrongback:masterfrom
Open
Creating Strongback gradle project structure#108jmcshane wants to merge 9 commits intostrongback:masterfrom
jmcshane wants to merge 9 commits intostrongback:masterfrom
Conversation
added 5 commits
March 8, 2017 20:41
Author
|
I'm working on resolving this failure now, check out the gradle-download-externals branch in my fork of this repository. I have wpilib resolving, now I just need to add the other ones. The code is rough for now, but I'm going to create a gradle plugin for downloading the latest version of each from the vendor. |
…rence any currently deployed version of wpilib to compile against
…on existing ant tasks, while using the gradle plugin for wpilib to specify the exact version rather than downloading from releases. This will force compilation of strongback to specific wpilib version and can publish multiple artifacts against these versions
Gradle - resolve external dependencies
jmcshane
changed the title
andrewda
suggested changes
Apr 29, 2017
andrewda
left a comment
andrewda
left a comment
There was a problem hiding this comment.
Other than these small styling inconsistencies, looks good! 👍
build-common.xml
Outdated
| <available file="${project.test.source.dir}" type="dir"/> | ||
| </condition> | ||
| </target> | ||
| </target> |
build.gradle
Outdated
|
|
||
| dependencies { | ||
| testCompile('junit:junit:4.12') | ||
| testCompile('org.easytesting:fest-assert:1.4') |
| gradleVersion = '2.10' | ||
| } | ||
|
|
||
| ant.importBuild 'third-party.xml' |
There was a problem hiding this comment.
Almost all other files use spaces. Is there a reason this one uses tabs?
Author
|
Thanks for the review. I'll try to get these changes pushed out this evening |
Author
|
All comments above have been resolved by 4af573a. |
CarlinWilliamson
added a commit
to Team3132/strongback-java
that referenced
this pull request
Jun 30, 2020
Templates for Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #92
NB: The ant structure will be maintained and this is still in progress
Please feel free to comment on the PR and address issues as I continue to work on this. I'm hoping to be able to help the teams that have an existing maven/gradle structure in their projects to be able to plugin strongback and strongback-testing right into their code.
Description
This conversion will allow the ant structure to be maintained and all existing ant tools to be preserved while allowing others to reference this gradle project and get the transitive dependencies that come with the project.
PR Status
Complete
build.gradlefile for the base projectTo Do
strongback.jarandstrongback-testing.jarwill leave this to repository owners