fix: use exact string amount for Solana balance instead of float round trip#103
Open
samarthpatel24 wants to merge 1 commit into
Open
fix: use exact string amount for Solana balance instead of float round trip#103samarthpatel24 wants to merge 1 commit into
samarthpatel24 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_balancewas usingui_amount(f64) from the Solana RPC and multiplying back to atomic units, causing floating-point precision loss (e.g.0.1 * 1_000_000→99999instead of100000)token_balance.amount(the exact atomic units string from the RPC) directly, matching the pattern already used by the EVM and Tempo providersTest plan
cargo checkpassesNetworkBalance.balance_atomicis already aStringfield