Fix panic when using EqualValues with uncomparable types #1825
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredbi
added a commit
to fredbi/testify
that referenced
this pull request
Dec 27, 2025
================================== Panic situation is explained by stretchr#1699 The fix from the original author (@ccoVeille) has been adapted into our refactored assertions (with unit test). fix: avoid panic on invalid regexp ================================== Merged stretchr#1818 The original issue is described by: stretchr#1794 The original code contributed by @kdt523 has been adapted to our refactored assertions (with tests), taking into account the review comments from @ccoVeille. Thanks folks. fix: documented the fixed merged from github.com/stretchr/testify ================================== * fixes go-openapi#7 Also: since a dependency has been removed in the previous refactoring, updated the NOTICE to reflect this fact. Signed-off-by: Frederic BIDON <[email protected]>
fredbi
added a commit
to go-openapi/testify
that referenced
this pull request
Dec 27, 2025
================================== Panic situation is explained by stretchr#1699 The fix from the original author (@ccoVeille) has been adapted into our refactored assertions (with unit test). fix: avoid panic on invalid regexp ================================== Merged stretchr#1818 The original issue is described by: stretchr#1794 The original code contributed by @kdt523 has been adapted to our refactored assertions (with tests), taking into account the review comments from @ccoVeille. Thanks folks. fix: documented the fixed merged from github.com/stretchr/testify ================================== * fixes #7 Also: since a dependency has been removed in the previous refactoring, updated the NOTICE to reflect this fact. Signed-off-by: Frederic BIDON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix panic when using EqualValues with uncomparable types
Changes
Add calls to CanConvert and CanInterface to avoid panics
Motivation
Avoid panic
Related issues
Closes #1699