refactor: Update the lists of files included in packages#3297
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request standardizes the files field configuration across multiple npm packages in the monorepo. The changes ensure that only necessary files are included in published packages by aligning patterns and removing references to non-existent files.
Key changes:
- Standardizes the
filesfield syntax across packages (e.g.,dist/→dist, specific tsbuildinfo paths →!*.tsbuildinfowildcard) - Removes LICENSE file references from packages where the file doesn't exist in the package directory
- Adds
filesfield to browser-test-runner to control published content - Removes
.npmignorefrom autocertifier-client in favor of thefilesfield approach used by all other packages
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/trackerless-network/package.json | Removes non-existent LICENSE file from published package contents |
| packages/test-utils/package.json | Standardizes directory pattern (dist/ → dist) and tsbuildinfo exclusion to match other packages |
| packages/browser-test-runner/package.json | Adds files field to control published content, including LICENSE file |
| packages/autocertifier-server/package.json | Removes non-existent LICENSE file reference from published package contents |
| packages/autocertifier-client/package.json | Removes references to non-existent README.md and LICENSE files |
| packages/autocertifier-client/.npmignore | Deletes .npmignore file to align with other packages that use only the files field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Mostly clean-up, and mostly about I've double-checked the lists of packed files with Merging in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the packaging configuration for several packages, focusing on standardizing the
filesfield inpackage.jsonand cleaning up ignored files. The main goal is to ensure that only the necessary files are included in published npm packages, improving consistency and reducing package size.Changes
Packaging and file inclusion improvements:
filesfield inpackage.jsonacross multiple packages to consistently includedist, exclude*.tsbuildinfo, and selectively include or removeREADME.mdandLICENSEfiles. (packages/autocertifier-client/package.json[1]packages/autocertifier-server/package.json[2]packages/test-utils/package.json[3]packages/trackerless-network/package.json[4]packages/browser-test-runner/package.json[5]filesfield topackages/browser-test-runner/package.jsonto ensure only the necessary files are published..npmignoreinpackages/autocertifier-client– thefilesfield now controls published content.1Footnotes
autocertifier-clientwas the only package with.npmignore. It also hadfilesin itspackage.json. Now it's just like all the other packages – driven by thefilesfield *only*. ↩