Skip to content

refactor: Remove "browser" tsconfig jsons#3286

Merged
mondoreale merged 4 commits into
mainfrom
remove-browser-tsconfig-jsons
Dec 11, 2025
Merged

refactor: Remove "browser" tsconfig jsons#3286
mondoreale merged 4 commits into
mainfrom
remove-browser-tsconfig-jsons

Conversation

@mondoreale

Copy link
Copy Markdown
Contributor

This pull request removes several tsconfig.browser.json files from multiple packages and updates the corresponding tsconfig.karma.json files to extend from the shared root configuration instead. This streamlines TypeScript configuration across packages, reducing redundancy and potential inconsistencies.

TypeScript configuration cleanup:

  • Deleted tsconfig.browser.json files from the following packages to consolidate configuration into the shared root config: autocertifier-server, cdn-location, geoip-location, proto-rpc, sdk, trackerless-network, and utils.

Test configuration updates:

  • Updated tsconfig.karma.json files in dht, proto-rpc, trackerless-network, and utils to extend from the shared root config (../../tsconfig.browser.json) instead of the deleted package-local config, and added necessary compiler options and includes directly.
  • Ensured that all updated tsconfig.karma.json files explicitly specify outDir, noImplicitOverride, and the appropriate include paths.

@github-actions github-actions Bot added network Related to Network Package dht Related to DHT package utils proto-rpc sdk labels Dec 11, 2025

@teogeb teogeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root level tsconfig.browser.json could be renamed to tsconfig.karma.json as it is only referenced from tsconfig.karma.json files?

@@ -1,24 +0,0 @@
{

@teogeb teogeb Dec 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no tsconfig.karma.json in sdk. That file is there for all other packages which run browser tests (dht, trackerless-network, proto-rpc, utils). Is it ok that the file is missing in sdk? If the file is not needed there, why it needed in these other packages?

(Maybe sdk is a special case, but asking for clarification as I don't remember the reason at the moment).

Not strictly related to this PR.

@mondoreale mondoreale Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK does not use createWebpackConfig from browser-test-runner – that's what points to the tsconfig. The SDK has its very own custom webpack config setup (also for karma).

Base automatically changed from reindent-tsconfigs to main December 11, 2025 23:12
Karma is the only thing that uses it, and package-level karma tsconfigs extend it.
@mondoreale mondoreale merged commit 99a1610 into main Dec 11, 2025
42 of 43 checks passed
@mondoreale mondoreale deleted the remove-browser-tsconfig-jsons branch December 11, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dht Related to DHT package network Related to Network Package proto-rpc sdk utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants