refactor [NET-1654]: Clean-up tsconfigs for the utils package#3278
Closed
mondoreale wants to merge 2 commits into
Closed
refactor [NET-1654]: Clean-up tsconfigs for the utils package#3278mondoreale wants to merge 2 commits into
utils package#3278mondoreale wants to merge 2 commits into
Conversation
Contributor
Author
|
Closing in favour or #3301. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates TypeScript configuration files across multiple packages to improve project references and build consistency. The main change is standardizing how the
utilspackage is referenced in varioustsconfigfiles, switching from referencing its config file directly to referencing the package directory. Additionally, theutilspackage receives several updates to its own config files and scripts to streamline builds and checks.Changes
Project reference updates:
utilspackage intsconfig.jest.jsonandtsconfig.node.jsonfiles across packages (such asautocertifier-client,autocertifier-server,cdn-location,dht,geoip-location,node,proto-rpc,test-utils, andcli-tools) to use{ "path": "../utils" }instead of{ "path": "../utils/tsconfig.node.json" }for better compatibility with TypeScript project references.utilspackage configuration improvements:tsconfig.jsonto theutilspackage, enabling composite builds and referencing all relevant config files (tsconfig.jest.json,tsconfig.node.json,tsconfig.karma.json).tsconfig.jest.jsoninutilsto only include thetestdirectory and added a reference to its owntsconfig.node.jsonfor improved separation of test and source code.Build and check script enhancements:
buildscript inutils/package.jsonto usetsc -bfor composite builds, and updated thecheckscript to run both Jest and Node TypeScript checks for stricter type safety.Cleanup:
tsconfig.browser.jsonfile from theutilspackage, reducing clutter.