refactor [NET-1646]: Clean-up tsconfigs for the cli-tools package#3270
Merged
Conversation
mondoreale
force-pushed
the
net-1646-clean-up-cli-tools-package-tsconfigs
branch
from
67fe16b to
3a31694
Compare
mondoreale
force-pushed
the
net-1646-clean-up-cli-tools-package-tsconfigs
branch
from
93cff2c to
a30133f
Compare
vsc uses source code, `tsc -b` uses .d.ts – the new flag consolidates the 2 (we use .d.ts now).
It's ok this way now.
teogeb
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates TypeScript configuration for the
cli-toolspackage to improve project references and build reliability. The changes primarily enhance how the package manages its dependencies and build process, ensuring better integration with related packages and more robust project setup.Changes
TypeScript project configuration improvements:
tsconfig.node.jsonandtsconfig.jest.jsonfordht,trackerless-network, andtest-utilsto ensure proper dependency tracking and type checking.tsconfig.node.jsonas a reference in the maintsconfig.jsonforcli-tools, clarifying the build order and dependencies.package.jsonto theincludearray intsconfig.jest.jsonto ensure it is considered in type checking and builds.Build process and compiler options:
buildscript inpackage.jsonto use the default TypeScript project references build (tsc -b), making the build process more consistent.disableSourceOfProjectReferenceRedirectcompiler option in the roottsconfig.node.jsonto prevent issues with source file redirection in project references.Other adjustments:
compositeoption fromcli-tools/tsconfig.node.json, as it is now managed at a higher level.