You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this patch ended up being slightly more complex than initially expected because we need to support multiple versions of sv2-apps. Until this point, we had not encountered any breaking changes in the configuration file format.
the approach taken in this PR is intentionally minimal: introduce version-aware branching logic in the configuration generator and place the user_identity field in the location expected by each supported version.
specifically:
For sv2-apps v0.3.5, user_identity is written at the top level of the configuration.
For the current main branch, user_identity is written under the upstream section.
This ensures compatibility with both versions while keeping the change set small and focused on resolving the immediate issue.
ps: I would recommend revisiting this implementation in the future. As we begin supporting additional versions of sv2-apps, the current branching approach may become increasingly difficult to maintain. A more structured versioning strategy for configuration generation would likely be beneficial in the long term. For now, however, this solution provides a practical fix for the main branch and unblocks affected users.
ps: I would recommend revisiting this implementation in the future. As we begin supporting additional versions of sv2-apps, the current branching approach may become increasingly difficult to maintain. A more structured versioning strategy for configuration generation would likely be beneficial in the long term. For now, however, this solution provides a practical fix for the main branch and unblocks affected users.
The good thing is that after the work on bitcoin_core_sv2 defined here, we won't need to handle different apps' versions anymore.
So when those changes land on sv2-apps, we can finally remove all this branching logic which we introduced up to now.
The good thing is that after the work on bitcoin_core_sv2 defined stratum-mining/sv2-apps#516, we won't need to handle different apps' versions anymore.
So when those changes land on sv2-apps, we can finally remove all this branching logic which we introduced up to now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #174.
this patch ended up being slightly more complex than initially expected because we need to support multiple versions of
sv2-apps. Until this point, we had not encountered any breaking changes in the configuration file format.the approach taken in this PR is intentionally minimal: introduce version-aware branching logic in the configuration generator and place the
user_identityfield in the location expected by each supported version.specifically:
sv2-apps v0.3.5,user_identityis written at the top level of the configuration.mainbranch,user_identityis written under theupstreamsection.This ensures compatibility with both versions while keeping the change set small and focused on resolving the immediate issue.
ps: I would recommend revisiting this implementation in the future. As we begin supporting additional versions of
sv2-apps, the current branching approach may become increasingly difficult to maintain. A more structured versioning strategy for configuration generation would likely be beneficial in the long term. For now, however, this solution provides a practical fix for the main branch and unblocks affected users.