add coinbase_witness field to NewTemplate#198
Draft
plebhash wants to merge 1 commit into
Draft
Conversation
- add `NewTemplate.coinbase_witness` to TDP as `B0_32` - define conditional encoding: - empty when witness commitment output is omitted - exactly 32 bytes when witness commitment output is present - codify BIP141 empty-block behavior (witness commitment optional) - require clients to preserve TP-provided output ordering as `<client-added-outputs> || <NewTemplate.coinbase_tx_outputs>` - clarify field purpose: serialize coinbase witness coherently with TP commitment output; no witness-commitment recomputation required - update Protocol Overview BIP141 text to match the new rules
plebhash
force-pushed
the
2026-06-09-new-template-coinbase-witness
branch
from
5faa219 to
1bd0189
Compare
|
ack |
This was referenced Jun 16, 2026
Contributor
|
ACK 1bd0189 I updated stratum-mining/sv2-tp#108 to match. How do you want to go about deploying this? It's probably safest if you first update SRI to optionally handle this extra field. I could then release a new sv2-tp version that sets the field, and note in its release notes the minimum expected SRI release. Or we could do something more graceful like bumping a protocol number? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #166
as discussed in #156 (TLDR: future-proofing Sv2 TDP wrt future/potential BIP141-related consensus changes)
note: this PR is similar to #15, which was opened in 2022 and closed in 2023 with pending review comments and no merging
so I'm trying to preemptively address some confusion points that were left as pending review comments on #15