add asic-rs telemetry data in tProxy and JDC monitoring#553
Conversation
75323b3 to
389235d
Compare
389235d to
dcd9ad7
Compare
Shourya742
left a comment
There was a problem hiding this comment.
For some reason I am not able to add suggestions. weird. Did a first pass of code review.
d1a17fd to
24cdfdf
Compare
|
we should bump MAJOR for |
|
tACK a few observations about
|
That's not supposed to happen...
Not on the supported miner list, happy to add it though... Could you open issues for both of these on asic-rs and we can go into more detail there? |
|
@GitGab19 whats the reason why we don't have this for JDC, as sv2 native miners can connect to it directly as well, and we might want this for those connections? |
The scope of this PR is adding I see the value in leveraging In that PR we might move some shared logic in |
4ef28aa to
203d426
Compare
203d426 to
104d719
Compare
asic-rs telemetry data in tProxy monitoringasic-rs telemetry data in tProxy and JDC monitoring
|
I added Most of the common logic between tProxy and JDC have been moved to This PR is now ready for review again. |
This PR adds
asic-rsas a dependency and uses its APIs to enrich tProxy and JDC monitoring data with telemetry data of every miner supported byasic-rs.I had to bump MSRV from
1.85to1.88, as we already discussed in #443.Here the results with my Bitaxe Gamma connected to tProxy:
cc @b-rowan @pavlenex
Closes #445
Closes #567