chore: cleanup#260
Merged
Merged
Conversation
COil
commented
Jun 18, 2026
Member
| Q | A |
|---|---|
| Branch? | main |
| Cleanup? | yes |
| New feature? | no |
| Doc added? | yes |
| Tests pass? | yes |
| Deprecations? | no |
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup around Markdown rendering on the homepage and aligns a couple of DTO namespaces with their directory structure, while adding a regression test for blank-input handling.
Changes:
- Mark
add_headers_anchorsas safe HTML, suppress libxml warnings, and add an early return for blank input. - Update the homepage Twig pipeline to remove unnecessary
|rawand adjust filter order. - Move DTO namespaces (
RegisterFormDto,ListUsersActionDto) and update imports/usages accordingly; add a regression test case.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Integration/Twig/Extension/MarkdownExtensionTest.php | Adds coverage for blank/empty input handling in addHeadersAnchors(). |
| templates/App/Controller/HomeAction.html.twig | Removes extra ` |
| src/Twig/Extension/MarkdownExtension.php | Marks filter output as safe HTML, adds blank-input guard, and manages libxml warnings. |
| src/Form/Type/RegisterForm.php | Updates DTO import to the new namespace. |
| src/Dto/Form/Type/RegisterFormDto.php | Moves DTO namespace under Dto/Form/Type and adjusts imports. |
| src/Dto/Controller/ListUsersActionDto.php | Fixes namespace to match file location (App\Dto\Controller). |
| src/Data/Controller/ListUsersActionData.php | Updates DTO import to the new namespace. |
| src/Controller/FormAction.php | Updates DTO import to the new namespace. |
Comments suppressed due to low confidence (1)
src/Dto/Form/Type/RegisterFormDto.php:12
- After moving this DTO to
App\Dto\Form\Type,@see FormActionno longer resolves (it will now point toApp\Dto\Form\Type\FormAction). Import the controller (or use its FQCN) so the reference stays correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.