Skip to content

chore: cleanup#260

Merged
COil merged 3 commits into
mainfrom
chore/cleanup
Jun 18, 2026
Merged

chore: cleanup#260
COil merged 3 commits into
mainfrom
chore/cleanup

Conversation

@COil

@COil COil commented Jun 18, 2026

Copy link
Copy Markdown
Member
Q A
Branch? main
Cleanup? yes
New feature? no
Doc added? yes
Tests pass? yes
Deprecations? no

@COil COil requested a review from Copilot June 18, 2026 16:46
@COil COil self-assigned this Jun 18, 2026
@COil COil added the improvement improvement of an existing feature label Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs cleanup around Markdown rendering on the homepage and aligns a couple of DTO namespaces with their directory structure, while adding a regression test for blank-input handling.

Changes:

  • Mark add_headers_anchors as safe HTML, suppress libxml warnings, and add an early return for blank input.
  • Update the homepage Twig pipeline to remove unnecessary |raw and adjust filter order.
  • Move DTO namespaces (RegisterFormDto, ListUsersActionDto) and update imports/usages accordingly; add a regression test case.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/Integration/Twig/Extension/MarkdownExtensionTest.php Adds coverage for blank/empty input handling in addHeadersAnchors().
templates/App/Controller/HomeAction.html.twig Removes extra `
src/Twig/Extension/MarkdownExtension.php Marks filter output as safe HTML, adds blank-input guard, and manages libxml warnings.
src/Form/Type/RegisterForm.php Updates DTO import to the new namespace.
src/Dto/Form/Type/RegisterFormDto.php Moves DTO namespace under Dto/Form/Type and adjusts imports.
src/Dto/Controller/ListUsersActionDto.php Fixes namespace to match file location (App\Dto\Controller).
src/Data/Controller/ListUsersActionData.php Updates DTO import to the new namespace.
src/Controller/FormAction.php Updates DTO import to the new namespace.
Comments suppressed due to low confidence (1)

src/Dto/Form/Type/RegisterFormDto.php:12

  • After moving this DTO to App\Dto\Form\Type, @see FormAction no longer resolves (it will now point to App\Dto\Form\Type\FormAction). Import the controller (or use its FQCN) so the reference stays correct.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Twig/Extension/MarkdownExtension.php
Comment thread templates/App/Controller/HomeAction.html.twig
@COil COil merged commit dbac7fe into main Jun 18, 2026
5 checks passed
@COil COil deleted the chore/cleanup branch June 18, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants