feat(sprocket test): output assertions#565
Conversation
e6071fb to
0dfe8ec
Compare
0dfe8ec to
792e812
Compare
|
Just off the top of my head, during our meeting. Arrays: |
|
A few more, though I'm not tied to the naming: Map: Anything more complex is probably going to need to be a custom assertion. The same is true for testing |
I want to think this over some more, but I think you're right. IMO the currently implemented set of assertions is about good for the "essential" assertions for this PR, but it should be easy to extend the set in future PRs. At least, I'm going to stop implementing more unless someone asks for more specifically. Now time to write tests for all of this, which I'm not looking forward to 😭 |
passing `-v` overrides the filtering
This commit replaces the custom writer implementation with using a reloadable `LevelFilter` as the first layer in logging. By using a level filter as the first layer, we can turn the filter off and prevent events from reaching the next layers. Unlike turning of the writer, this prevents any additional work the other layers may perform.
claymcleod
left a comment
There was a problem hiding this comment.
Left a few comments after reviewing.
claymcleod
left a comment
There was a problem hiding this comment.
Whoops, forgot to include these in the last review!
Co-authored-by: Clay McLeod <3411613+claymcleod@users.noreply.github.com>
Co-authored-by: Adam C. Foltzer <acfoltzer@acfoltzer.net>
Co-authored-by: Clay McLeod <3411613+claymcleod@users.noreply.github.com> Co-authored-by: Andrew Thrasher <adthrasher@gmail.com> Co-authored-by: Peter Huene <peter@huene.dev>
Describe the problem or feature in addition to a link to the issues.
New user guide for these features - stjude-rust-labs/sprocket.bio#29
There is a strange
serdebug which causes the YAML syntax used in this PR to deviate from the syntax used in theserde_yaml_ngdocs. See this commit for details 9fbc964 that link to acatton/serde-yaml-ng#14 which links to more informationThis is a bit of a "happy accident" bug IMO, as I prefer the alternate syntax used here as opposed to the YAML tag syntax the documentation uses.
I've started adding these to stjudecloud/workflows#263
Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository (when appropriate).For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.