Unify plain/gz PDB parsing and fix short-record handling in gz reader - #46
Open
nz-mtra wants to merge 1 commit into
Open
Unify plain/gz PDB parsing and fix short-record handling in gz reader#46nz-mtra wants to merge 1 commit into
nz-mtra wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes
This PR removes divergence between plain and gz PDB parsing by introducing one shared line parser in pdb.rs. Fixes #45 .
Changes included:
Why
Previously, gz and plain PDB readers used separate parsing paths. That made behavior drift possible and exposed gz parsing to short-record edge cases. The new shared parser keeps behavior aligned and prevents this class of divergence moving forward.
Validation
Executed and passing:
Notes
The new regression tests assert plain/gz behavior parity and non-crashing behavior for END-terminated inputs, which directly targets the reported bug class.