fix(build): go-generate-fast, run-status-backend #7266
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* c78009bcfa9e does not exist * original repo has been updated, no need in replace
* needed to find libsds.h header
friofry
requested review from
Copilot and
igor-sirotin
and removed request for
igor-sirotin
There was a problem hiding this comment.
Pull request overview
This PR addresses two build-related issues: removing a dependency override for go-generate-fast after the upstream repository was updated, and fixing the make run-status-backend command to properly include the nim-sds library dependencies.
- Removes the
replacedirective forgo-generate-fastto use the upstream v0.3.0 release - Adds
$(LIBSDS)dependency and CGO flags to therun-status-backendtarget to resolve library linking errors
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Removes the replace directive that pointed to a non-existent commit in status-im's fork, allowing use of upstream v0.3.0 |
| go.sum | Updates checksums to reflect the switch from status-im's fork to the upstream oNaiPs/go-generate-fast v0.3.0 |
| Makefile | Adds $(LIBSDS) as a dependency and passes CGO_CFLAGS and CGO_LDFLAGS to ensure nim-sds library is properly linked when running status-backend |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Jenkins Builds
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7266 +/- ##
===========================================
- Coverage 60.49% 60.40% -0.09%
===========================================
Files 815 815
Lines 113163 113163
===========================================
- Hits 68454 68357 -97
- Misses 37661 37747 +86
- Partials 7048 7059 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
replace go-generate-fastfrom go.modThe upstream repo
github.com/oNaiPs/go-generate-fasthas been updated. Non-existent commit causedgo mod tidyto failFix
make run-status-backendfailing withlibsds.hnot found errorAdded
$(LIBSDS)to nim-sds library cmdline when missing. PassCGO_CFLAGSandCGO_LDFLAGS