feat(multiaccount): add back functions to delete a multiaccount #7263
+99
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins Builds
|
saledjenic
reviewed
Dec 24, 2025
| return errors.New("accounts db wasn't initialized") | ||
| } | ||
|
|
||
| err := b.multiaccountsDB.DeleteAccount(keyUID) |
Contributor
There was a problem hiding this comment.
@jrainville should we check before get to this line if the account being deleted is not the last multiaccount?
Member
Author
There was a problem hiding this comment.
In theory there is no harm deleting the last one, it should just go back to the first stage of onboarding without the selector.
The use case is if someone only has one account, forgets their password, but still has the seed phrase, they can delete the profile and reimport
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7263 +/- ##
===========================================
- Coverage 60.40% 60.40% -0.01%
===========================================
Files 815 815
Lines 113163 113220 +57
===========================================
+ Hits 68360 68393 +33
- Misses 37740 37756 +16
- Partials 7063 7071 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 task
saledjenic
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-app#15350
It was deleted as "not used" because desktop didn't have it yet, but we planned to use it. This was the commit: d96dfaa#diff-37b0477fdcc303b15489e4502027610f4a45ee12b564c48b7ccb45439e0c4b74
I only brought back
DeleteMultiaccountV2, but removed the V2 part. I updated the test to work with the new way of managing accounts, which is pleasantly way simpler.