#542 Add first draft for chronos-multithreading docs #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Dec 29, 2025
| proc cleanupThread*() {.gcsafe, raises: [].}= | ||
| {.cast(gcsafe).}: | ||
| try: | ||
| `=destroy`(getThreadDispatcher()) |
Member
There was a problem hiding this comment.
Finally had time to look into this problem a bit more - while this trick releases the (ORC) memory held by the dispatcher, the bigger issue is that the other resources (such as the IOCP/selector) still cause a leak per thread (since one selector is allocated per thread).
Instead of this partial solution, I think that the documentation would do better to document the status quo:
"On thread exit, some thread-local resources used by chronos are not released - it is recommended to use a thread pool and reuse chronos threads for this reason. For more information, see issue https:/// ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for what I learned with chronos in multithreading so far and how that could be turned into docs as discussed in #542 .
If you had a different vision @arnetheduck let me know, I'll see what I can do.
Note that I think a rather obvious question that I do not yet know the answer for is:
"What do I do when I want the thread to end, but the Dispatcher still has work on it? How do I tell it to process the remaining work?"
If I had an answer to that I'd gladly add an example to the docs.