Skip to content

starknet_patricia: actually preallocate filled-tree output map capacity #14809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkaempfer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

starknet_patricia: actually preallocate filled-tree output map capacity #14809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions crates/starknet_patricia/src/patricia_merkle_tree/filled_tree/tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,16 @@ impl<L: Leaf + 'static> FilledTreeImpl<L> {
fn initialize_filled_tree_output_map_with_placeholders<'a>(
updated_skeleton: &impl UpdatedSkeletonTree<'a>,
) -> HashMap<NodeIndex, OnceLock<HashFilledNode<L>>> {
updated_skeleton
.get_nodes()
.filter_map(|(index, node)| match node {
UpdatedSkeletonNode::UnmodifiedSubTree(_) => None,
_ => Some((*index, OnceLock::new())),
})
.collect()
let nodes_iter = updated_skeleton.get_nodes();
// `filter_map`'s `size_hint` lower bound is always 0 (the predicate can drop every
// item), so collecting through it directly would not preallocate. Reserve capacity
// from the unfiltered iterator's exact size instead, then extend into it.
let mut filled_tree_output_map = HashMap::with_capacity(nodes_iter.size_hint().0);
filled_tree_output_map.extend(nodes_iter.filter_map(|(index, node)| match node {
UpdatedSkeletonNode::UnmodifiedSubTree(_) => None,
_ => Some((*index, OnceLock::new())),
}));
filled_tree_output_map
}

fn initialize_leaf_output_map_with_placeholders(
Expand Down
Loading