Skip to content

apollo_consensus_orchestrator,apollo_batcher,apollo_batcher_types: drop accessed_keys from blob#14808

Open
yoavGrs wants to merge 1 commit into
mainfrom
remove-accessed-keys-from-blob
Open

apollo_consensus_orchestrator,apollo_batcher,apollo_batcher_types: drop accessed_keys from blob#14808
yoavGrs wants to merge 1 commit into
mainfrom
remove-accessed-keys-from-blob

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Remove the os_input-gated accessed_keys: AccessedKeys field from AerospikeBlob and its dead
plumbing: the matching BlobParameters field, the blob construction, and the now-unused
CentralObjects.accessed_keys (its only reader was the blob build). The batcher still computes
the block's accessed keys for the committer and for trimming initial_reads; only the blob no
longer carries them.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

yoavGrs commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

…op accessed_keys from blob

Remove the os_input-gated `accessed_keys: AccessedKeys` field from `AerospikeBlob` and its dead
plumbing: the matching `BlobParameters` field, the blob construction, and the now-unused
`CentralObjects.accessed_keys` (its only reader was the blob build). The batcher still computes
the block's accessed keys for the committer and for trimming `initial_reads`; only the blob no
longer carries them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yoavGrs yoavGrs force-pushed the remove-accessed-keys-from-blob branch from a3b312a to 7181c50 Compare July 15, 2026 07:33
@yoavGrs yoavGrs changed the title apollo_consensus_orchestrator,apollo_batcher,apollo_batcher_types: drop accessed_keys from AerospikeBlob apollo_consensus_orchestrator,apollo_batcher,apollo_batcher_types: drop accessed_keys from blob Jul 15, 2026
@yoavGrs yoavGrs marked this pull request as ready for review July 15, 2026 08:31
@yoavGrs yoavGrs self-assigned this Jul 15, 2026
@cursor

cursor Bot commented Jul 15, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Dead-field removal on the blob/CentralObjects wire path; batcher still persists accessed keys and trims initial_reads locally, so OS input behavior is unchanged aside from a smaller serialized blob.

Overview
Removes the os_input-gated accessed_keys field from the Cende Aerospike blob and the types that feed it, so the recorder payload no longer duplicates data the OS does not need there.

CentralObjects no longer carries accessed_keys; decision_reached still returns initial_reads only. BlobParameters, AerospikeBlob, and the orchestrator path that builds the next-height blob drop the matching field and imports.

The batcher unchanged in behavior for local OS prep: it still runs write_block_accessed_keys, passes accessed keys into the commitment path, and uses them to trim_to_accessed_keys on initial_reads before those reads go upstream.

Central-object serialization tests stop stripping accessed_keys from JSON comparisons (only recent_state_commitment_infos and initial_reads remain os_input-only exclusions).

Reviewed by Cursor Bugbot for commit 7181c50. Bugbot is set up for automated code reviews on this repo. Configure here.

@yoavGrs yoavGrs requested a review from itamar-starkware July 15, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants