You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
publish the linux/arm64 transaction-prover release artifact without a CPU-specific TARGET_CPU
retain the existing znver5 tuning for the AMD64 artifact
The current ARM64 release is compiled for neoverse-v2, which enables instructions unavailable on Apple Silicon. The published multi-architecture tag selects this true ARM64 image on M3 Docker hosts, where it exits with SIGILL before becoming healthy. Leaving TARGET_CPU empty makes the Dockerfile use Rust's generic AArch64 baseline while preserving the existing ARM64 image and manifest layout.
Validation
git diff --check
YAML syntax parse
confirmed the Dockerfile only sets -C target-cpu=... when TARGET_CPU is non-empty
A native ARM64 startup smoke test can be added separately once an appropriate runner/test RPC fixture is available.
Low Risk
CI-only matrix change with no application logic; may slightly reduce ARM64 proving performance on Neoverse hardware in exchange for broader portability.
Overview ARM64 release images are no longer built with TARGET_CPU=neoverse-v2. The publish workflow matrix now passes an empty target_cpu for linux/arm64, with a comment that release tags must use the generic AArch64 baseline (including Linux containers on Apple Silicon).
AMD64 is unchanged: the workflow still sets target_cpu: znver5 for linux/amd64. The Dockerfile already skips -C target-cpu when TARGET_CPU is empty, so ARM64 builds use Rust’s default portable AArch64 codegen instead of Neoverse-specific instructions that caused SIGILL on M-series hosts.
Reviewed by Cursor Bugbot for commit 8567b9c. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux/arm64transaction-prover release artifact without a CPU-specificTARGET_CPUznver5tuning for the AMD64 artifactThe current ARM64 release is compiled for
neoverse-v2, which enables instructions unavailable on Apple Silicon. The published multi-architecture tag selects this true ARM64 image on M3 Docker hosts, where it exits withSIGILLbefore becoming healthy. LeavingTARGET_CPUempty makes the Dockerfile use Rust's generic AArch64 baseline while preserving the existing ARM64 image and manifest layout.Validation
git diff --check-C target-cpu=...whenTARGET_CPUis non-emptyA native ARM64 startup smoke test can be added separately once an appropriate runner/test RPC fixture is available.