fix linked item issues in Super editor#2918
Merged
Merged
Conversation
antsgar
commented
Jul 21, 2025
antsgar
commented
Contributor
- Fixes linked items being embedded twice when clicking on them in the typeahead instead of pressing Enter
- Fixes the Remove button not doing anything when clicked for embedded linked items
antsgar
commented
Jul 21, 2025
| }, | ||
| [linkingController, node, editor], | ||
| ) | ||
| const unlinkPressed = useCallback(async () => { |
Contributor
Author
There was a problem hiding this comment.
The actual unlinking here is unnecessary because it happens through the NodeObserverPlugin
Member
There was a problem hiding this comment.
Thanks, was just about to ask that.
amanharwara
approved these changes
Jul 21, 2025
| }, | ||
| [linkingController, node, editor], | ||
| ) | ||
| const unlinkPressed = useCallback(async () => { |
Member
There was a problem hiding this comment.
Thanks, was just about to ask that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.