chore: remove options to add new embeds and render existing twitter embeds as links#2917
Merged
Conversation
antsgar
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the options to add new twitter and youtube embeds since it doesn't really make sense to have those and also changes the existing tweet embed nodes to be rendered as a link instead. The tweet embeds were already not working due to content security policy and the Chrome Web Store is rejecting updates because the twitter widget code violates its mv3 rules by including remotely hosted code. This change also only changes how a tweet node is rendered and doesn't do any sort of transformation of a note's actual content.