chore: Improve release workflows#2916
Conversation
| run: yarn run webpack --config desktop.webpack.prod.js | ||
| - name: AppImage | ||
| run: yarn run electron-builder --linux --x64 -c.linux.target=AppImage --publish=never --c.extraMetadata.version=${{ env.APP_VERSION }} | ||
| run: | |
There was a problem hiding this comment.
The native modules are currently being rebuilt once before the packaging for both architectures happens. I suspect that might be the reason the native modules are always x64 and the arm64 Linux packages aren't running properly (see standardnotes/forum#3457). This is an attempt to fix the issue
| - name: Rebuild Electron Native Modules | ||
| run: yarn workspace @standardnotes/desktop rebuild:home-server | ||
|
|
||
| - run: yarn build:desktop |
There was a problem hiding this comment.
This is the same as yarn run webpack --config desktop.webpack.prod.js which runs below I think?
|
|
||
| - run: echo APP_VERSION=$(node -p "require('./../web/package.json').version") >> $GITHUB_ENV | ||
|
|
||
| - name: Compile for AppImage |
There was a problem hiding this comment.
Now done in each step after rebuilding
| "@babel/preset-env": "*", | ||
| "@electron/notarize": "^3.0.0", | ||
| "@electron/rebuild": "3.6.0", | ||
| "@electron/rebuild": "3.6.1", |
There was a problem hiding this comment.
There's a fix on 3.6.1 which might affect rebuilding for different platforms electron/rebuild#1153
| submission_information: { add_id_info_uses_idfa: false }, | ||
| release_notes: { | ||
| 'default': 'Fixes and improvements.' | ||
| 'en-US': 'Fixes and improvements.' |
There was a problem hiding this comment.
Attempt to fix the current error in the mobile workflow, which fails in this command stating the release_notes field is missing
amanharwara
left a comment
amanharwara
left a comment
There was a problem hiding this comment.
LGTM at a glance. Only way to test this afaik is to merge and trigger a new release
2 participants
No description provided.