fix: prevent setting negative item created at timestamps#2913
Merged
Conversation
antsgar
force-pushed
the
fix/prevent-negative-created-at-timestamps
branch
from
379a217 to
85fb321
Compare
atmoio
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we have some logic preventing a payload from having a negative
created_atorupdated_attimestamp, when only the date fields are set and not the timestamp ones, the condition checking for a negative timestamp is not triggered. The timestamp is afterwards calculated from the date attributes, and if those correspond to a date before 1970-01-01, a negative timestamp is stored in the database.This PR updates the logic so that it also checks for a
created_atorupdated_atfield where the date is before 1970-01-01.