Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the MCP proxy configuration and agent MCP initialization to support loading user-defined (“external”) MCP servers from an on-disk config file, including the ability to disable configured servers and to substitute environment variables in configured env values.
Changes:
- Add
disabledsupport to MCP server entries and filter disabled servers during config parsing. - Add
$VAR/${VAR}environment-variable substitution forenvvalues in command-based MCP server configs. - In agent mode, auto-load external MCP servers from the discovered MCP proxy config file (with reserved-name protection), and expose the config discovery helper for reuse.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
libs/mcp/proxy/src/client/mod.rs |
Adds disabled flag support, env-var substitution for command env vars, and tests for these behaviors. |
cli/src/commands/mcp/mod.rs |
Makes find_mcp_proxy_config_file public so other CLI modules can reuse config discovery. |
cli/src/commands/agent/run/mcp_init.rs |
Loads external MCP servers into the proxy config during agent initialization (skipping reserved server names). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rejected server names
…management and factor out the management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.