Skip to content

Feat/load external mcps#677

Open
shehab299 wants to merge 13 commits intostakpak:mainfrom
shehab299:feat/load_external_mcps
Open

Feat/load external mcps#677
shehab299 wants to merge 13 commits intostakpak:mainfrom
shehab299:feat/load_external_mcps

Conversation

@shehab299
Copy link
Copy Markdown
Collaborator

No description provided.

@shehab299 shehab299 marked this pull request as draft March 31, 2026 02:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the MCP proxy configuration and agent MCP initialization to support loading user-defined (“external”) MCP servers from an on-disk config file, including the ability to disable configured servers and to substitute environment variables in configured env values.

Changes:

  • Add disabled support to MCP server entries and filter disabled servers during config parsing.
  • Add $VAR / ${VAR} environment-variable substitution for env values in command-based MCP server configs.
  • In agent mode, auto-load external MCP servers from the discovered MCP proxy config file (with reserved-name protection), and expose the config discovery helper for reuse.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
libs/mcp/proxy/src/client/mod.rs Adds disabled flag support, env-var substitution for command env vars, and tests for these behaviors.
cli/src/commands/mcp/mod.rs Makes find_mcp_proxy_config_file public so other CLI modules can reuse config discovery.
cli/src/commands/agent/run/mcp_init.rs Loads external MCP servers into the proxy config during agent initialization (skipping reserved server names).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shehab299 shehab299 marked this pull request as ready for review April 6, 2026 04:30
@shehab299 shehab299 requested a review from ahmedhesham6 April 6, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants