Fix copied WSL skill commands on Windows

[OrcaWin]

Summary

• keep copied WSL skill commands native to the target POSIX shell
• preserve Orca's PowerShell-to-WSL wrapper for the setup terminal it opens
• carry the selected runtime through Settings, onboarding, feature walls, and Linear setup surfaces

Reproduction and root cause

On native Windows with WSL Ubuntu selected, the generated 1,188-character command began with PowerShell's & { ... }. Orca's inline setup pane correctly opened PowerShell and accepted that draft, but Copy command exposed the same PowerShell-only string; pasting it into Ubuntu Bash failed immediately at the leading & with exit code 2.

The command builder was serving both clipboard and Orca-owned terminal destinations despite their different shell dialects. This change keeps the clipboard value as the 73-character npx skills ... command and applies the selected-distro PowerShell wrapper only at the setup-terminal boundary.

Validation

• 102 relevant Vitest tests passed; one Unix-only case is skipped on Windows
• added coverage for clipboard text, PowerShell setup-terminal wrapping, distro preservation, Settings, onboarding, and Linear setup
• changed-file formatting and all three Oxlint scans passed
• web typecheck and max-lines ratchet passed
• real Ubuntu Bash parse-only check of the copied command returned exit code 0
• Electron dev build on native Windows visibly showed the bare copy command and the wsl.exe -d 'Ubuntu' wrapper in Orca's inline PowerShell terminal; the real Copy action wrote the bare command to the clipboard

The installation payload was intentionally not executed because that would mutate global agent-skill state.

Risk

The wrapper remains conditional on a local Windows client, WSL runtime, and PowerShell-owned setup terminal. Host, macOS, Linux, remote/SSH, WSL distro selection, and folder-workspace routing retain their existing paths.

STA-3735

[OrcaWin]

Native Windows Electron validation

This is the full, uncropped Orca window after selecting the WSL Ubuntu runtime and clicking Install in the real CLI skill setup panel. The command row visibly contains the bare npx skills add ... --global command, while the inline terminal visibly contains a PowerShell draft that targets wsl.exe -d 'Ubuntu'; CDP inspection confirmed the app identity was OrcaWin/sta-3735-windows-repro, and exercising the real Copy command action wrote the same 73-character bare command to the clipboard.

Dev launch mode reports launch_mode_unavailable and normally hides this panel, so validation temporarily exposed only that existing visibility guard before hot reload. That validation-only adjustment was reverted before testing and is absent from commit 6664370039; the install draft was not executed because doing so would mutate global skill state.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 06fe1ad2-6e65-402b-86ba-f1a8e2d1d7dd

📥 Commits

Reviewing files that changed from the base of the PR and between 8aa81bd and 6ac33ff.

📒 Files selected for processing (3)

• src/renderer/src/components/settings/AgentSkillSetupPanel.test.tsx
• src/renderer/src/components/settings/AgentSkillSetupPanel.tsx
• src/renderer/src/components/settings/agent-skill-terminal-snapshot.ts

---

📝 Walkthrough

Walkthrough

Skill setup flows now pass the selected agent runtime to AgentSkillSetupPanel. Runtime-specific commands are built separately from terminal shell wrappers. Windows WSL terminals now receive generated wsl.exe commands, while clipboard actions retain normalized POSIX commands. WSL, host fallback, captured runtime, duplicate-wrapper, and non-Windows scenarios receive updated test coverage.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: fixing copied WSL skill commands on Windows.
Description check	✅ Passed	The description clearly explains the user-visible fix, root cause, validation, affected platforms, and risk, although several template headings are omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2616c540-1212-4717-bc8c-64edfb37dc93

📥 Commits

Reviewing files that changed from the base of the PR and between bbcf89e and 6664370.

📒 Files selected for processing (25)

• src/renderer/src/components/feature-tips/CliSkillSetupTerminal.tsx
• src/renderer/src/components/feature-wall/BrowserUseSkillSetupCard.tsx
• src/renderer/src/components/floating-terminal/FloatingTerminalOrchestrationDialog.tsx
• src/renderer/src/components/onboarding/FeatureSetupInlineTerminal.test.tsx
• src/renderer/src/components/onboarding/FeatureSetupInlineTerminal.tsx
• src/renderer/src/components/onboarding/onboarding-feature-setup.test.ts
• src/renderer/src/components/settings/AgentSkillSetupPanel.test.tsx
• src/renderer/src/components/settings/AgentSkillSetupPanel.tsx
• src/renderer/src/components/settings/BrowserUsePane.tsx
• src/renderer/src/components/settings/BrowserUseSkillStep.tsx
• src/renderer/src/components/settings/CliSection.test.tsx
• src/renderer/src/components/settings/CliSection.tsx
• src/renderer/src/components/settings/CliSkillRuntimeSetup.test.tsx
• src/renderer/src/components/settings/CliSkillRuntimeSetup.tsx
• src/renderer/src/components/settings/ComputerUseSkillSetupPanel.tsx
• src/renderer/src/components/settings/EphemeralVmsPane.tsx
• src/renderer/src/components/settings/LinearAgentSkillPane.tsx
• src/renderer/src/components/settings/OrchestrationPane.tsx
• src/renderer/src/components/settings/OrchestrationSetupCard.tsx
• src/renderer/src/components/settings/TaskSourceLinearSetup.tsx
• src/renderer/src/components/settings/agent-skill-setup-panel-props.ts
• src/renderer/src/components/settings/use-linear-agent-skill-setup.ts
• src/renderer/src/components/sidebar/LinearAgentSkillSetupDialog.tsx
• src/renderer/src/components/sidebar/LinearAgentSkillSetupPrompt.test.tsx
• src/renderer/src/components/sidebar/LinearAgentSkillSetupPrompt.tsx

[OrcaWin]

STA-3735 Windows Electron QA (post-review)

Verdict: PASS (with noted gaps)
Exact head validated: 6ac33ff31fc32382dfc734f203039a4bb1bd3e8d
Method: Electron CDP (playwright-cli on REMOTE_DEBUGGING_PORT=9336 only). No Computer Use. No product-code edits. Install payload intentionally not executed.

Focused Vitest

CliSkillRuntimeSetup, AgentSkillSetupPanel, CliSkillSetupTerminal, CliSection, FeatureSetupInlineTerminal — 58 passed, 1 skipped (pin / retry / repair-fallback covered).

E2E (Settings → Orchestration skill, default runtime WSL/Ubuntu)

Check	Result
Copy command is bare npx skills add ... --skill orchestration --global (no PowerShell wrap)	PASS — clipboard len 78; Ubuntu bash -n exit 0
Install opens pwsh setup terminal with wsl.exe -d 'Ubuntu' draft; panel <code> stays bare	PASS
Open terminal frozen after settings Ubuntu→Fedora	PASS — still wsl.exe -d 'Ubuntu'
Missing WSL distro (Fedora) surfaces repair + disables Install	PASS
Missing-WSL host fallback + retry snapshot	PASS (unit); live paths partial (see report)

Screenshots

Copy dialog — bare POSIX npx (no & { ... }):

Setup terminal — PowerShell draft wraps WSL Ubuntu; visible command stays bare:

Missing WSL distro (Fedora) — repair message, Install disabled:

Orchestration skill panel (WSL/Ubuntu selected):

Final setup terminal (Ubuntu wrap, post-renderer check):

Evidence (recoverable, evidence-only)

• Full QA report: https://raw.githubusercontent.com/OrcaWin/orca/qa-evidence/sta-3735-6ac33ff31f/qa-evidence/sta-3735/STA-3735-QA-REPORT.md
• All PNGs + report (branch qa-evidence/sta-3735-6ac33ff31f): https://github.com/OrcaWin/orca/tree/qa-evidence/sta-3735-6ac33ff31f/qa-evidence/sta-3735
• Evidence commit: OrcaWin@e06e2e2

gh image session-token upload remains unavailable on this Windows host (browser cookie stores locked / missing); images published to the OrcaWin evidence-only orphan branch instead (not on the PR product branch).

Gaps (not regressions of this PR)

1. Dev electron-vite launch hides Settings → General → Orca CLI → Agent skills via launch_mode_unavailable; Orchestration skill exercised as the shared AgentSkillSetupPanel surface.
2. Live Retry / feature-tip host-fallback not fully re-shown; unit coverage is strong.
3. Install payload not executed end-to-end (by design).

Conclusion

At 6ac33ff31fc32382dfc734f203039a4bb1bd3e8d, Windows/WSL skill-command split, open-terminal pin, and repair UI hold under real Windows Electron CDP for the Orchestration skill setup path.