Fix signatures and add latestTask details#30
Open
taylorferran wants to merge 6 commits intossvlabs:mainfrom
Open
Fix signatures and add latestTask details#30taylorferran wants to merge 6 commits intossvlabs:mainfrom
taylorferran wants to merge 6 commits intossvlabs:mainfrom
Conversation
RaekwonIII
reviewed
Jun 10, 2025
RaekwonIII
previously approved these changes
Jun 10, 2025
riccardo-ssvlabs
suggested changes
Jun 11, 2025
RaekwonIII
requested changes
Jun 11, 2025
taylorferran
force-pushed
the
bapp-contract-template
branch
from
7e856eb to
d8c69ea
Compare
RaekwonIII
approved these changes
Jun 13, 2025
| allTaskHashes[latestTaskNum] = taskHash; | ||
| allTaskHashes[nextTaskNumber] = taskHash; | ||
| latestTaskNum = nextTaskNumber; | ||
| nextTaskNumber = nextTaskNumber + 1; |
Contributor
There was a problem hiding this comment.
this could probably use ++ but that's ok for the example
| mapping(uint32 => bytes32) public allTaskHashes; | ||
| mapping(address => mapping(uint32 => bytes)) public allTaskResponses; | ||
| uint32 public latestTaskNum; | ||
| uint32 public latestTaskNum; // Tracks the current task |
Contributor
There was a problem hiding this comment.
I would consider removing comments cause they are redundant. But it's ok.
| bytes[] calldata signatures, | ||
| address[] calldata signers, | ||
| uint32 strategyId | ||
| uint32[] calldata strategyIds |
Contributor
There was a problem hiding this comment.
For the future these 3 params could go in a struct and then you would pass an array of these structs. So you don't have to check the length.
| @@ -87,7 +95,7 @@ contract EthPriceOracle is OwnableBasedApp { | |||
| } else { | |||
| // if strategy has no signer set, check the signer is the owner of the strategy | |||
Contributor
There was a problem hiding this comment.
what happens here in the else if if (strategySignerAddress != signers[i])?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This let's the contract work with multiple signatures and gives more details to the user on the contract.